dex: evict excess of liquidity positions #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
added
consensus-breaking
erwanor
force-pushed
the
erwan/end_block_eviction
branch
from
7917244
to
f733274
Compare
erwanor
commented
May 31, 2024
erwanor
commented
May 31, 2024
|
I have tested this manually on a devnet using a tweaked version of |
erwanor
commented
May 31, 2024
cratelyn
approved these changes
May 31, 2024
There was a problem hiding this comment.
this looks good to me. nice work! i found a bug in our "recently accessed assets" logic, but i see that it comes from preexisting code, so i don't consider it blocking this change, despite it being a part of the diff.
the logic looks good, and the refactorings along the way have great side-effects. 🙂
Co-authored-by: katelyn martin <[email protected]> Signed-off-by: Erwan Or <[email protected]>
Co-authored-by: katelyn martin <[email protected]> Signed-off-by: Erwan Or <[email protected]>
this is a small change. this is a nice property about our data model, i.e. that an owned copy of the dex parameters may be used to make routing parameters. let's make that relationship explicit by putting it into a `From<T>` impl, and pulling it out of the `StateReadExt` logic.
zbuc
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
StateWriteExtand trim the dex component's public interfaceIssue ticket number and link
Final step to implement #4077
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: